Added Differential Diffusion to Auraflow. #9597
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @asomoza or @a-r-r-o-w for a review! |
a-r-r-o-w
reviewed
Oct 8, 2024
| f" {negative_prompt_attention_mask.shape}." | ||
| ) | ||
|
|
||
| def encode_prompt( |
There was a problem hiding this comment.
Could you add a # Copied from here?
| max_sequence_length: int = 256, | ||
| output_type: Optional[str] = "pil", | ||
| return_dict: bool = True, | ||
| map: PipelineImageInput = None, |
There was a problem hiding this comment.
I think docstring of this is missing
| def denoising_value_valid(dnv): | ||
| return isinstance(dnv, float) and 0 < dnv < 1 | ||
|
|
||
| # sigmas = np.linspace(1.0, 1 / num_inference_steps, num_inference_steps) |
There was a problem hiding this comment.
Suggested change
| # sigmas = np.linspace(1.0, 1 / num_inference_steps, num_inference_steps) |
Comment on lines
+624
to
+629
| # timesteps, num_inference_steps = self.get_timesteps( | ||
| # num_inference_steps, | ||
| # strength, | ||
| # device, | ||
| # denoising_start=self.denoising_start if denoising_value_valid(self.denoising_start) else None, | ||
| # ) |
There was a problem hiding this comment.
Why has this been removed? If I understand correctly from other implementations, this is required, yes?
| # compute the previous noisy sample x_t -> x_t-1 | ||
| latents = self.scheduler.step(noise_pred, t, latents, return_dict=False)[0] | ||
|
|
||
| # call the callback, if provided |
There was a problem hiding this comment.
Were the callback related parts removed here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes partially #8924
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
How to test
Who can review?
@a-r-r-o-w @DN6